[webkit-reviews] review granted: [Bug 170207] AssemblyHelpers should not have a VM field : [Attachment 305656] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 28 15:56:46 PDT 2017
Yusuke Suzuki <utatane.tea at gmail.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 170207: AssemblyHelpers should not have a VM field
https://bugs.webkit.org/show_bug.cgi?id=170207
Attachment 305656: patch
https://bugs.webkit.org/attachment.cgi?id=305656&action=review
--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 305656
--> https://bugs.webkit.org/attachment.cgi?id=305656
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=305656&action=review
r=me with comments.
> Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp:-50
> -
Why is this dropped?
> Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp:-54
> -
Ditto.
> Source/JavaScriptCore/ftl/FTLThunks.cpp:169
> + AssemblyHelpers jit(0);
Let's use nullptr.
> Source/JavaScriptCore/jit/AssemblyHelpers.h:-977
> - void debugCall(V_DebugOperation_EPP function, void* argument)
Why is this utility dropped? I think it is still useful (And I think moving it
to cpp file is better).
More information about the webkit-reviews
mailing list