[webkit-reviews] review granted: [Bug 168409] [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout : [Attachment 305648] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 168409: [mac-wk1] LayoutTest
media/modern-media-controls/airplay-button/airplay-button.html is a flaky
timeout
https://bugs.webkit.org/show_bug.cgi?id=168409

Attachment 305648: Patch

https://bugs.webkit.org/attachment.cgi?id=305648&action=review




--- Comment #41 from Dean Jackson <dino at apple.com> ---
Comment on attachment 305648
  --> https://bugs.webkit.org/attachment.cgi?id=305648
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305648&action=review

> Source/WebCore/dom/ScriptedAnimationController.cpp:84
> +    dispatchLoggingEventIfRequired("raf-suspend");

GTK is failing because this function expects an AtomicString, not a char*.

You either want something like AtomicString("raf-suspend",
AtomicString::ConstructFromLiteral)
or
ASCIILiteral("raf-suspend") (which itself will do a conversion)