[webkit-reviews] review granted: [Bug 170166] Stop RTCDataChannel when closing page : [Attachment 305597] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170166: Stop RTCDataChannel when closing page
https://bugs.webkit.org/show_bug.cgi?id=170166

Attachment 305597: Patch

https://bugs.webkit.org/attachment.cgi?id=305597&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 305597
  --> https://bugs.webkit.org/attachment.cgi?id=305597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305597&action=review

> Source/WebCore/Modules/mediastream/RTCDataChannel.h:93
> +    bool canSuspendForDocumentSuspension() const final { return false; }

It seems this should at least return true when readyState is ReadyStateClosed.