[webkit-reviews] review granted: [Bug 169046] Web Inspector: Option-clicking the close tab button should close all other tabs : [Attachment 305517] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 169046: Web Inspector: Option-clicking the close tab button should close
all other tabs
https://bugs.webkit.org/show_bug.cgi?id=169046

Attachment 305517: Patch

https://bugs.webkit.org/attachment.cgi?id=305517&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 305517
  --> https://bugs.webkit.org/attachment.cgi?id=305517
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305517&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TabBar.js:617
> +	       if (event.altKey) {

Suggested early return:

if (!event.altKey) {
    this.removeTabBarItem(tabBarItem, false, true);
    return;
}