[webkit-reviews] review granted: [Bug 170118] addIceCandidate should not throw if passed null or undefined : [Attachment 305485] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170118: addIceCandidate should not throw if passed null or undefined
https://bugs.webkit.org/show_bug.cgi?id=170118

Attachment 305485: Patch

https://bugs.webkit.org/attachment.cgi?id=305485&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 305485
  --> https://bugs.webkit.org/attachment.cgi?id=305485
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305485&action=review

>
LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeercon
nection-idl-expected.txt:82
> +FAIL RTCPeerConnection interface: calling addIceCandidate([object
Object],[object Object]) on pc with too few arguments must throw TypeError
assert_unreached: Should have rejected: undefined Reached unreachable code

is this expected?