[webkit-reviews] review granted: [Bug 170065] Web Inspector: Resource Details Sidebar displays previous image metrics when viewing resource where content load failed : [Attachment 305306] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 170065: Web Inspector: Resource Details Sidebar displays previous image
metrics when viewing resource where content load failed
https://bugs.webkit.org/show_bug.cgi?id=170065

Attachment 305306: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=305306&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 305306
  --> https://bugs.webkit.org/attachment.cgi?id=305306
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=305306&action=review

>> Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:458
>> +		    hideImageSection.call(this);
> 
> An alternative would be to show the section and have emdash values. But
seeing as we hide the section above if the `resource.failed` I matched that
here.

r=me. I like this approach, rather than showing emdash values. Cuts down on
clutter.