[webkit-reviews] review granted: [Bug 170121] webkitpy: Use host pattern for devices : [Attachment 305484] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 170121: webkitpy: Use host pattern for devices
https://bugs.webkit.org/show_bug.cgi?id=170121

Attachment 305484: Patch

https://bugs.webkit.org/attachment.cgi?id=305484&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 305484
  --> https://bugs.webkit.org/attachment.cgi?id=305484
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305484&action=review

> Tools/ChangeLog:9
> +	   throughout webkitpy.  Add the needed properties and

This sentence does not read well.

> Tools/Scripts/webkitpy/port/device.py:36
> +	   try:

Is it necessary to use a try-catch? I do not see the harm in having a Python
exception thrown if this property does not exist in the platform device. Such
an exception would tell us either that we need to implement this functionality
or that the caller must conditionalize the call to this property.

> Tools/Scripts/webkitpy/port/device.py:43
> +	   try:

Ditto.

> Tools/Scripts/webkitpy/port/device.py:50
> +	   try:

Ditto

> Tools/Scripts/webkitpy/port/device.py:57
> +	   try:

Ditto.

> Tools/Scripts/webkitpy/port/device.py:64
> +	   try:

Ditto.