[webkit-reviews] review granted: [Bug 168994] Bots should run the dashboard tests : [Attachment 304968] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jason Marcell
<jmarcell at apple.com>'s request for review:
Bug 168994: Bots should run the dashboard tests
https://bugs.webkit.org/show_bug.cgi?id=168994

Attachment 304968: Patch

https://bugs.webkit.org/attachment.cgi?id=304968&action=review




--- Comment #9 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 304968
  --> https://bugs.webkit.org/attachment.cgi?id=304968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304968&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:329
> +    resultDirectory = "layout-test-results"

Nit: Would prefer this to be named 'resultsDirectory' (plural 'results') to
match the command-line switch.