[webkit-reviews] review granted: [Bug 168517] [Modern Media Controls] Clicking on the tracks button when the tracks panel is up in a media document pauses the video : [Attachment 305467] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 27 08:11:05 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 168517: [Modern Media Controls] Clicking on the tracks button when the
tracks panel is up in a media document pauses the video
https://bugs.webkit.org/show_bug.cgi?id=168517

Attachment 305467: Patch

https://bugs.webkit.org/attachment.cgi?id=305467&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 305467
  --> https://bugs.webkit.org/attachment.cgi?id=305467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305467&action=review

> Source/WebCore/html/MediaDocument.cpp:197
> +    // pause or 

Nit: "when to pause or ..."


More information about the webkit-reviews mailing list