[webkit-reviews] review granted: [Bug 170081] Tighten RTCDatachannel creation and parameter getters : [Attachment 305330] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170081: Tighten RTCDatachannel creation and parameter getters
https://bugs.webkit.org/show_bug.cgi?id=170081

Attachment 305330: Patch

https://bugs.webkit.org/attachment.cgi?id=305330&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 305330
  --> https://bugs.webkit.org/attachment.cgi?id=305330
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305330&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:335
> +    if (options.negotiated && !options.negotiated.value() && (label.length()
> 65535 || options.protocol.length() > 65535))

USHRT_MAX?

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:341
> +    if (options.id && options.id.value() > 65534)

">= USHRT_MAX"? If not, a named constant would be nice to make it obvious what
this limit represents.