[webkit-reviews] review granted: [Bug 170083] Add font-optical-sizing to CSSComputedStyleDeclaration : [Attachment 305334] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 170083: Add font-optical-sizing to CSSComputedStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=170083

Attachment 305334: Patch

https://bugs.webkit.org/attachment.cgi?id=305334&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 305334
  --> https://bugs.webkit.org/attachment.cgi?id=305334
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305334&action=review

r=me

> LayoutTests/fast/text/variations/optical-sizing.html:34
> +var x = window.getComputedStyle(document.getElementById('test1'));

Could have a better name of this variable, like "computedStyle".

> LayoutTests/fast/text/variations/optical-sizing.html:40
> +		found = true;
> +		testPassed("Found optical sizing");
> +		break;

Nit: Double indentation here is weird.