[webkit-reviews] review granted: [Bug 167699] Serialization of custom props in longhand should be "" not value of shorthand : [Attachment 305329] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 167699: Serialization of custom props in longhand should be "" not value of
shorthand
https://bugs.webkit.org/show_bug.cgi?id=167699

Attachment 305329: Patch

https://bugs.webkit.org/attachment.cgi?id=305329&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 305329
  --> https://bugs.webkit.org/attachment.cgi?id=305329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305329&action=review

> LayoutTests/fast/css/variables/rule-property-get.html:9
> +/* https://www.w3.org/TR/css-variables/#variables-in-shorthands
> +   "Pending-substitution values must be serialized as the empty string, if
an API allows them to be observed." */

I think this comment could use some context, explaining what the test is
testing.