[webkit-reviews] review granted: [Bug 167935] [Modern Media Controls] Remove placard icon if height is compressed : [Attachment 305315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 24 14:39:53 PDT 2017


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 167935: [Modern Media Controls] Remove placard icon if height is compressed
https://bugs.webkit.org/show_bug.cgi?id=167935

Attachment 305315: Patch

https://bugs.webkit.org/attachment.cgi?id=305315&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 305315
  --> https://bugs.webkit.org/attachment.cgi?id=305315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305315&action=review

>
LayoutTests/media/modern-media-controls/layout-node/node-made-dirty-during-comm
it.html:25
> +const node = new CustomNode;
> +node.x = 20;

See! This is why JS const is crap.


More information about the webkit-reviews mailing list