[webkit-reviews] review granted: [Bug 170051] [Modern Media Controls] Captions don't move with the appearance of the inline controls : [Attachment 305280] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 24 12:25:11 PDT 2017
Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 170051: [Modern Media Controls] Captions don't move with the appearance of
the inline controls
https://bugs.webkit.org/show_bug.cgi?id=170051
Attachment 305280: Patch
https://bugs.webkit.org/attachment.cgi?id=305280&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 305280
--> https://bugs.webkit.org/attachment.cgi?id=305280
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=305280&action=review
> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:221
> +
this.host.textTrackContainer.classList.toggle("compact-controls-bar",
!!(layoutTraits & LayoutTraits.Compact));
I don't think you need the !! here.
More information about the webkit-reviews
mailing list