[webkit-reviews] review granted: [Bug 169258] font-style needs a new CSSValue to make CSSRule.cssText work correctly : [Attachment 305268] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 169258: font-style needs a new CSSValue to make CSSRule.cssText work
correctly
https://bugs.webkit.org/show_bug.cgi?id=169258

Attachment 305268: Patch

https://bugs.webkit.org/attachment.cgi?id=305268&action=review




--- Comment #15 from Dave Hyatt <hyatt at apple.com> ---
Comment on attachment 305268
  --> https://bugs.webkit.org/attachment.cgi?id=305268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305268&action=review

r=me

> Source/WebCore/css/CSSFontStyleValue.h:30
> +#include "FontSelectionAlgorithm.h"

Don't think you need this include, right?

> Source/WebCore/css/CSSFontValue.cpp:48
> -    if (weight) {
> +    if (stretch) {

Hah!