[webkit-reviews] review granted: [Bug 168290] Web Inspector: RTL: number scripts are used inconsistently throughout the UI : [Attachment 304760] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 168290: Web Inspector: RTL: number scripts are used inconsistently
throughout the UI
https://bugs.webkit.org/show_bug.cgi?id=168290

Attachment 304760: Patch

https://bugs.webkit.org/attachment.cgi?id=304760&action=review




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 304760
  --> https://bugs.webkit.org/attachment.cgi?id=304760
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304760&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DataGridNode.js:387
> +	       return "\u200b"; // Zero width space to keep the cell from
collapsing.

Maybe we should make a named variable for this in Utilities.js (like emDash).

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:754
> -	       this._timelineRuler.formatLabelCallback = (value) =>
value.toFixed(0);
> +	       this._timelineRuler.formatLabelCallback = (value) =>
value.maxDecimals(0).toLocaleString();

I understood all the other changes, but why the toFixed -> maxDecimals here?