[webkit-reviews] review granted: [Bug 169947] AX: Media controls are unlabeled : [Attachment 305239] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 24 01:16:26 PDT 2017

Antoine Quint <graouts at apple.com> has granted Aaron Chu <aaron_chu at apple.com>'s
request for review:
Bug 169947: AX: Media controls are unlabeled

Attachment 305239: Patch


--- Comment #9 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 305239
  --> https://bugs.webkit.org/attachment.cgi?id=305239

Looks good! While this could land as-is, I think we might want to refactor
imageForIconNameAndLayoutTraits() into imageForIconAndLayoutTraits() and pass
the icon and directly and let that function look up its name instead of
explicitly passing it around.

More information about the webkit-reviews mailing list