[webkit-reviews] review granted: [Bug 169947] AX: Media controls are unlabeled : [Attachment 305239] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted Aaron Chu <aaron_chu at apple.com>'s
request for review:
Bug 169947: AX: Media controls are unlabeled
https://bugs.webkit.org/show_bug.cgi?id=169947

Attachment 305239: Patch

https://bugs.webkit.org/attachment.cgi?id=305239&action=review




--- Comment #9 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 305239
  --> https://bugs.webkit.org/attachment.cgi?id=305239
Patch

Looks good! While this could land as-is, I think we might want to refactor
imageForIconNameAndLayoutTraits() into imageForIconAndLayoutTraits() and pass
the icon and directly and let that function look up its name instead of
explicitly passing it around.