[webkit-reviews] review granted: [Bug 169993] Share more code between ManifestGenerator and /api/triggerables : [Attachment 305165] Cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 23 13:51:35 PDT 2017


Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 169993: Share more code between ManifestGenerator and /api/triggerables
https://bugs.webkit.org/show_bug.cgi?id=169993

Attachment 305165: Cleanup

https://bugs.webkit.org/attachment.cgi?id=305165&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 305165
  --> https://bugs.webkit.org/attachment.cgi?id=305165
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=305165&action=review

r=me

> Websites/perf.webkit.org/ChangeLog:14
> +	   (ManifestGenerator::fetch_triggearables): Extracted as a static
function. Also include the ID

Typo: fetch_triggearables


More information about the webkit-reviews mailing list