[webkit-reviews] review granted: [Bug 170016] Let the UI process do memory kills and replace crashes with diagnostic logging. : [Attachment 305212] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 170016: Let the UI process do memory kills and replace crashes with
diagnostic logging.
https://bugs.webkit.org/show_bug.cgi?id=170016

Attachment 305212: Patch

https://bugs.webkit.org/attachment.cgi?id=305212&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 305212
  --> https://bugs.webkit.org/attachment.cgi?id=305212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305212&action=review

r=me with comments.

> Source/WebKit2/ChangeLog:13
> +	   Also add drive-by diagnostic logging for background CPU limit kills.

thank you

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:1131
> +void WebProcessProxy::simulateProcessCrash(const String& reason)

I think this should take in an enum rather than a logging key. Logging is
internal logic and I don't like that call sites have to pass in a logging key.

> Source/WebKit2/UIProcess/WebProcessProxy.h:169
> +    void simulateProcessCrash(const String& reason);

Could be private.