[webkit-reviews] review granted: [Bug 169896] Web Inspector: Editing local storage keys/values starts with truncated strings : [Attachment 305203] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 23 10:35:10 PDT 2017


Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 169896: Web Inspector: Editing local storage keys/values starts with
truncated strings
https://bugs.webkit.org/show_bug.cgi?id=169896

Attachment 305203: Patch

https://bugs.webkit.org/attachment.cgi?id=305203&action=review




--- Comment #11 from Brian Burg <bburg at apple.com> ---
Comment on attachment 305203
  --> https://bugs.webkit.org/attachment.cgi?id=305203
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305203&action=review

r=me

> Source/WebInspectorUI/ChangeLog:13
> +	   since it may get removed while editing.

You should mention that div.cell-content is removed because the <td> itself is
contenteditable (using the fancy
-webkit-user-modify:read-write-plaintext-only), not the inner div.cell-content.


More information about the webkit-reviews mailing list