[webkit-reviews] review granted: [Bug 169991] [Cocoa] Add an option to exclude overflow when snapshotting a WKWebProcessPlugInNodeHandle : [Attachment 305160] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 169991: [Cocoa] Add an option to exclude overflow when snapshotting a
WKWebProcessPlugInNodeHandle
https://bugs.webkit.org/show_bug.cgi?id=169991

Attachment 305160: Patch

https://bugs.webkit.org/attachment.cgi?id=305160&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 305160
  --> https://bugs.webkit.org/attachment.cgi?id=305160
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305160&action=review

>
Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle
.mm:71
> -    RefPtr<WebImage> image = _nodeHandle->renderedImage(options);
> +    RefPtr<WebImage> image =
_nodeHandle->renderedImage(toSnapshotOptions(options), options &
kWKSnapshotOptionsExcludeOverflow);

Maybe it's obvious and I'm missing it, but why not add a SnapshotOptions bit
for this?

>
Tools/TestWebKitAPI/Tests/WebKit2Cocoa/rendered-image-excluding-overflow.html:2
0
> +    <div class=container>
> +	   <div class=inner>

Missing quotes, eww :)