[webkit-reviews] review granted: [Bug 169978] Support RTCPeerConnectionState : [Attachment 305139] Patch

[bugzilla-daemon at webkit.org]

Jon Lee <jonlee at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 169978: Support RTCPeerConnectionState
https://bugs.webkit.org/show_bug.cgi?id=169978

Attachment 305139: Patch

https://bugs.webkit.org/attachment.cgi?id=305139&action=review




--- Comment #3 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 305139
  --> https://bugs.webkit.org/attachment.cgi?id=305139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305139&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-78
> -    // FIXME 169644: change to RTCSessionDescriptionInit

Why is this removed? The signature should be updated even if it's handled by
the builtin.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-147
> -    // FIXME 169644: convert to (MediaStreamTrack or DOMString)

Why is this removed?