[webkit-reviews] review granted: [Bug 168998] font shorthand should accept variation values : [Attachment 304961] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 22 15:54:42 PDT 2017

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 168998: font shorthand should accept variation values

Attachment 304961: Patch


--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 304961
  --> https://bugs.webkit.org/attachment.cgi?id=304961

View in context: https://bugs.webkit.org/attachment.cgi?id=304961&action=review

> Source/WebCore/ChangeLog:12
> +	   accepts percentages, which are also accepted by font-size, which
means those can't

"those" here is ambiguous.

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:202
> +    // Values less than or equal to 0 or greater than or equal to 1000 are
parse errors.

Is this covered in the testing?

More information about the webkit-reviews mailing list