[webkit-reviews] review granted: [Bug 169936] WebKit should disallow beforeunload alerts from web pages users have never interacted with : [Attachment 305118] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 169936: WebKit should disallow beforeunload alerts from web pages users
have never interacted with
https://bugs.webkit.org/show_bug.cgi?id=169936

Attachment 305118: Patch

https://bugs.webkit.org/attachment.cgi?id=305118&action=review




--- Comment #13 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 305118
  --> https://bugs.webkit.org/attachment.cgi?id=305118
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305118&action=review

Looks good. I had a question about whitespace in the test file, but nothing
critical.

>
LayoutTests/http/tests/misc/iframe-beforeunload-dialog-not-matching-ancestor-se
curityorigin.html:16
> +	   // Simulate a user interaction with the page so that the
beforeunload alert shows.

The indent on this comment looks strange. Is that what you intended? Or did we
get a tab in the file?