[webkit-reviews] review granted: [Bug 168912] [Soup] "Only from websites I visit" cookie policy is broken : [Attachment 305004] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 168912: [Soup] "Only from websites I visit" cookie policy is broken
https://bugs.webkit.org/show_bug.cgi?id=168912

Attachment 305004: Patch

https://bugs.webkit.org/attachment.cgi?id=305004&action=review




--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 305004
  --> https://bugs.webkit.org/attachment.cgi?id=305004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305004&action=review

>>
LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-redirect-ex
pected.txt:2
>> +This test PASS if you can see the text "FAILED: Cookie not set".
> 
> I'm not sure what you were thinking here, but this was a bad idea. :) Please
change the text to "PASS: Cookie not set".

I think this is because it's reusing the
cookies/resources/set-cookie-on-redirect.php that is used to test that cookies
are indeed set on redirect, but here we want to test the opposite.