[webkit-reviews] review granted: [Bug 169915] [GTK] Several WPT tests are failing since they were added in the last update in r213882 : [Attachment 305002] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 169915: [GTK] Several WPT tests are failing since they were added in the
last update in r213882
https://bugs.webkit.org/show_bug.cgi?id=169915

Attachment 305002: Patch

https://bugs.webkit.org/attachment.cgi?id=305002&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 305002
  --> https://bugs.webkit.org/attachment.cgi?id=305002
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305002&action=review

>
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/getallr
esponseheaders-expected.txt:3
> +FAIL XMLHttpRequest: getAllResponseHeaders() 1 assert_equals: expected
"also-here: Mr. PB\r\newok: lego\r\nfoo-test: 1, 2\r\n" but got "ALSO-here: Mr.
PB\r\nfoo-test: 1, 2\r\newok: lego\r\n"

IMO the test should be updated to print PASS for either result, so we don't
have the text FAIL in our expected results unnecessarily.