[webkit-reviews] review granted: [Bug 169937] EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade : [Attachment 305052] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 21 17:35:44 PDT 2017


Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 169937: EWS fails to parse_bug_id_from_attachment_page after bugzilla
upgrade
https://bugs.webkit.org/show_bug.cgi?id=169937

Attachment 305052: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=305052&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 305052
  --> https://bugs.webkit.org/attachment.cgi?id=305052
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305052&action=review

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:494
> +	   match = re.search("show_bug.cgi\?id=(?P<bug_id>\d+)", str(title))
>	   return int(match.group('bug_id'))

Can something be printed to the log if this fails?


More information about the webkit-reviews mailing list