[webkit-reviews] review granted: [Bug 169705] [jsc] Add MacroAssemblerMIPS::storeFence() : [Attachment 304565] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 169705: [jsc] Add MacroAssemblerMIPS::storeFence()
https://bugs.webkit.org/show_bug.cgi?id=169705

Attachment 304565: Patch

https://bugs.webkit.org/attachment.cgi?id=304565&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 304565
  --> https://bugs.webkit.org/attachment.cgi?id=304565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304565&action=review

r=me with comments.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2973
> +    {

Could you add a FIXME and comment about SYNC_MB thing?
And in FIXME, adding opened issue URL(in bugzilla) is desireable.