[webkit-reviews] review granted: [Bug 169923] [MediaStream] Make mock video source work on iOS : [Attachment 305027] Proposed patch.

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 169923: [MediaStream] Make mock video source work on iOS
https://bugs.webkit.org/show_bug.cgi?id=169923

Attachment 305027: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=305027&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 305027
  --> https://bugs.webkit.org/attachment.cgi?id=305027
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=305027&action=review

> Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.h:56
> +    RetainPtr<CVPixelBufferRef> pixelBufferFromCGImage(CGImageRef);

Keep it const and make m_bufferPool mutable?

> Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.h:60
> +    bool applySize(const IntSize&) override;

Use final.