[webkit-reviews] review granted: [Bug 174035] When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed : [Attachment 314322] Patch v1

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 174035: When setting a custom cookie storage location on a
WKWebsiteDataStore, cookies aren't actually removed
https://bugs.webkit.org/show_bug.cgi?id=174035

Attachment 314322: Patch v1

https://bugs.webkit.org/attachment.cgi?id=314322&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 314322
  --> https://bugs.webkit.org/attachment.cgi?id=314322
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:199
> +    // This time, reuse the same network process but still do a new
websitedatastore, to make sure even an existing network process
> +    // gets the new datastore.

No, the problem is described here.  If we have a new WebsiteDataStore and an
existing NetworkProcess, we need to tell it about the new WebsiteDataStore.