[webkit-reviews] review denied: [Bug 174001] Add API to get WKActivatedElementInfo : [Attachment 314339] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 30 17:56:28 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 174001: Add API to get WKActivatedElementInfo
https://bugs.webkit.org/show_bug.cgi?id=174001

Attachment 314339: Patch

https://bugs.webkit.org/attachment.cgi?id=314339&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314339
  --> https://bugs.webkit.org/attachment.cgi?id=314339
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314339&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h:37
> ++ (instancetype)_initWithInteractionInformationAtPosition:(const
WebKit::InteractionInformationAtPosition&)information;

Class methods should not start with 'init'. This should be
+ActivatedElementInfoAtPosition:

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:47
> +    auto webView = adoptNS([[TestWKWebView alloc]
initWithFrame:CGRectMake(0, 0, 320, 500)]);
> +    [webView loadHTMLString:@"<html><head><meta name='viewport'
content='initial-scale=1'></head><body style = 'margin: 0px;'><a
href='testURL.test' style='display: block; height: 100%;'
title='HitTestLinkTitle' id='testID'></a></body></html>" baseURL:nil];
> +    [webView _test_waitForDidFinishNavigation];
> +    
> +    __block bool finished = false;
> +    [webView _requestActivatedElementAtPosition:CGPointMake(50, 50)
completionBlock: ^(_WKActivatedElementInfo *elementInfo) {

This test would be more thorough if the content were scaled and zoomed.


More information about the webkit-reviews mailing list