[webkit-reviews] review granted: [Bug 173860] [iOS DnD] Text indicators for dragged links should always be legible if the link is legible : [Attachment 314315] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 30 16:36:26 PDT 2017
Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 173860: [iOS DnD] Text indicators for dragged links should always be
legible if the link is legible
https://bugs.webkit.org/show_bug.cgi?id=173860
Attachment 314315: Patch
https://bugs.webkit.org/attachment.cgi?id=314315&action=review
--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 314315
--> https://bugs.webkit.org/attachment.cgi?id=314315
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=314315&action=review
> Source/WebCore/page/TextIndicator.cpp:230
> + auto& color = node->renderer()->style().color();
Any need for a renderer null check? Any chance to get here with an anonymous
element?
More information about the webkit-reviews
mailing list