[webkit-reviews] review granted: [Bug 174044] RegExp's anchored with .* with \g flag can return wrong match start for strings with multiple matches : [Attachment 314302] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 174044: RegExp's  anchored with .* with \g flag can return wrong match
start for strings with multiple matches
https://bugs.webkit.org/show_bug.cgi?id=174044

Attachment 314302: Patch

https://bugs.webkit.org/attachment.cgi?id=314302&action=review




--- Comment #3 from Oliver Hunt <oliver at apple.com> ---
Comment on attachment 314302
  --> https://bugs.webkit.org/attachment.cgi?id=314302
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314302&action=review

> Source/JavaScriptCore/yarr/YarrJIT.cpp:2699
> +	   if (m_pattern.m_saveInitialStartValue) {
> +#ifdef HAVE_INITIAL_START_REG
> +	       move(index, initialStart);
> +#else
> +	       storeToFrame(index, m_pattern.m_initialStartValueFrameLocation);
> +#endif

I almost wish we could bludgeon templates into doing this for us. Almost. (I
suspect it would turn into "can I implement register allocation with templates
at compile time?" questions :D )