[webkit-reviews] review granted: [Bug 173890] Web Inspector: Modernize InjectedScriptSource : [Attachment 313980] [PATCH] Part 2 - Mostly mechanical (classes)

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted  review:
Bug 173890: Web Inspector: Modernize InjectedScriptSource
https://bugs.webkit.org/show_bug.cgi?id=173890

Attachment 313980: [PATCH] Part 2 - Mostly mechanical (classes)

https://bugs.webkit.org/attachment.cgi?id=313980&action=review




--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 313980
  --> https://bugs.webkit.org/attachment.cgi?id=313980
[PATCH] Part 2 - Mostly mechanical (classes)

View in context: https://bugs.webkit.org/attachment.cgi?id=313980&action=review

r=me on part 2

> Source/JavaScriptCore/inspector/InjectedScriptSource.js:951
> +	   this.className = InjectedScriptHost.internalConstructorName(object);

Not something to address in a class refactoring, but is there a reason that we
need to compute these eagerly instead of doing it in getters? I guess if we
immediately ship all of this to inspector it's OK to precompute it.