[webkit-reviews] review granted: [Bug 173840] Web Inspector: AsyncStackTrace nodes can be corrupted when truncating : [Attachment 313965] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 173840: Web Inspector: AsyncStackTrace nodes can be corrupted when
truncating
https://bugs.webkit.org/show_bug.cgi?id=173840

Attachment 313965: Patch

https://bugs.webkit.org/attachment.cgi?id=313965&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 313965
  --> https://bugs.webkit.org/attachment.cgi?id=313965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313965&action=review

> LayoutTests/inspector/debugger/truncate-async-stack-trace.html:5
> +<script src="resources/log-active-stack-trace.js"></script>

Is this script needed? Should the test be calling window.logActiveStackTrace to
verify something? Right now it just confirms it can pause, which I assume is
verifying that we aren't ASSERTing.