[webkit-reviews] review granted: [Bug 173437] Web Inspector: Add small delay before showing the progress spinner when loading resources : [Attachment 313027] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173437: Web Inspector: Add small delay before showing the progress spinner
when loading resources
https://bugs.webkit.org/show_bug.cgi?id=173437

Attachment 313027: Patch

https://bugs.webkit.org/attachment.cgi?id=313027&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 313027
  --> https://bugs.webkit.org/attachment.cgi?id=313027
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313027&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:40
> +	       // Append a spinner while waiting for contentAvailable. The
subclasses are responsible

Nit: "The subclasses are" => "Subclasses are"

You can also say in the comment "... by calling removeLoadingIndicator".

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:46
> +	   }, 50);

Lets make this 100 to match the ChangeLog.