[webkit-reviews] review granted: [Bug 174004] Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h : [Attachment 314251] Fixed the tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 30 13:15:59 PDT 2017
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 174004: Frame.h doesn't need to include FrameLoader.h, IntRect.h, and
NavigationScheduler.h
https://bugs.webkit.org/show_bug.cgi?id=174004
Attachment 314251: Fixed the tests
https://bugs.webkit.org/attachment.cgi?id=314251&action=review
--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314251
--> https://bugs.webkit.org/attachment.cgi?id=314251
Fixed the tests
View in context: https://bugs.webkit.org/attachment.cgi?id=314251&action=review
> Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:992
> + core(m_webFrame)->createView(enclosingIntRect(logicalFrame).size(),
backgroundColor, transparent, /* fixedLayoutSize */ IntSize(), /*
fixedVisibleContentRect */IntRect());
Can't the default args be "{ }"?
More information about the webkit-reviews
mailing list