[webkit-reviews] review granted: [Bug 173984] Web Inspector: Default string comparisons to treat numeric characters as numbers : [Attachment 314206] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 30 11:01:59 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173984: Web Inspector: Default string comparisons to treat numeric
characters as numbers
https://bugs.webkit.org/show_bug.cgi?id=173984

Attachment 314206: Patch

https://bugs.webkit.org/attachment.cgi?id=314206&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 314206
  --> https://bugs.webkit.org/attachment.cgi?id=314206
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314206&action=review

r=me

> LayoutTests/inspector/unit-tests/string-utilities.html:44
> +	       InspectorTest.expectEqual("1".extendedLocaleCompare("2"), -1,
`"1" < "2"`);
> +	       InspectorTest.expectEqual("2".extendedLocaleCompare("1"), 1,
`"2" > "1"`);
> +	       InspectorTest.expectEqual("2".extendedLocaleCompare("10"), -1,
`"2" < "10"`);
> +	       InspectorTest.expectEqual("10".extendedLocaleCompare("2"), 1,
`"10" > "2"`);
> +	       InspectorTest.expectEqual("1".extendedLocaleCompare("10"), -1,
`"1" < "10"`);
> +	       InspectorTest.expectEqual("10".extendedLocaleCompare("1"), 1,
`"10" > "1"`);

How does: "a2" compare to "a10"?
Can we have a test?

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:676
> +    value: function(other)

Style:

    value(other)


More information about the webkit-reviews mailing list