[webkit-reviews] review granted: [Bug 173993] [WebIDL] Add support for conditionally read-write attributes : [Attachment 314184] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 173993: [WebIDL] Add support for conditionally read-write attributes
https://bugs.webkit.org/show_bug.cgi?id=173993

Attachment 314184: Patch

https://bugs.webkit.org/attachment.cgi?id=314184&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 314184
  --> https://bugs.webkit.org/attachment.cgi?id=314184
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314184&action=review

> Source/WebCore/bindings/scripts/test/TestObj.idl:455
> +    [Conditional=CONDITION2, ConditionallyReadWrite=CONDITION] attribute
Node conditionalAndConditionallyReadWriteAttribute;

This test could be more clear if CONDITION were CONDITION3