[webkit-reviews] review granted: [Bug 173617] REGRESSION(r218371): Reeder's default font is Times instead of San Francisco : [Attachment 314258] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 173617: REGRESSION(r218371): Reeder's default font is Times instead of San
Francisco
https://bugs.webkit.org/show_bug.cgi?id=173617

Attachment 314258: Patch

https://bugs.webkit.org/attachment.cgi?id=314258&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314258
  --> https://bugs.webkit.org/attachment.cgi?id=314258
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314258&action=review

> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:86
> +    // The special cases in this function need to match the behavior in
FontDescriptionCocoa.cpp. On systems where
> +    // USE_PLATFORM_SYSTEM_FALLBACK_LIST is set to true, this code is used
when src:local(special-cased-name) is
> +    // specified inside an @font-face block, and the code in
FontDescriptionCocoa.cpp is used for regular (element
> +    // style) lookups.
> +    // FIXME: Currently, an @font-face block corresponds to a single item in
the font-family: fallback list, which
> +    // means that "src:local(system-ui)" can't follow the Core Text cascade
list (the way it does for regular lookups).
> +    // These two behaviors should be unified, which would hopefully allow us
to delete this duplicate code.

Maybe have this comment in just one place, and in the other say "// FIXME: see
comment in ..."