[webkit-reviews] review granted: [Bug 174005] DFG_ASSERT should allow stuffing registers before trapping. : [Attachment 314214] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 174005: DFG_ASSERT should allow stuffing registers before trapping.
https://bugs.webkit.org/show_bug.cgi?id=174005

Attachment 314214: Patch

https://bugs.webkit.org/attachment.cgi?id=314214&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 314214
  --> https://bugs.webkit.org/attachment.cgi?id=314214
Patch

Regarding the use of CRASH_WITH_SECURITY_IMPLICATION, I talked with Keith
offline and we agree that we'll:
1. define a DFG_CRASH_WITH_SECURITY_IMPLICATION() if not already defined.  By
default, it will be define to CRASH(). 
2. This DFG_ASSERT code will use DFG_CRASH_WITH_SECURITY_IMPLICATION() instead
of CRASH() directly.

r=me with fixes.