[webkit-reviews] review granted: [Bug 172768] [JSC] WTFGetBacktrace can return numberOfFrames == 0 in some architectures : [Attachment 314215] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 29 20:26:23 PDT 2017
Keith Miller <keith_miller at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 172768: [JSC] WTFGetBacktrace can return numberOfFrames == 0 in some
architectures
https://bugs.webkit.org/show_bug.cgi?id=172768
Attachment 314215: Patch
https://bugs.webkit.org/attachment.cgi?id=314215&action=review
--- Comment #15 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 314215
--> https://bugs.webkit.org/attachment.cgi?id=314215
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=314215&action=review
r=me with some changes.
> Source/WTF/ChangeLog:8
> + In some architectures, like ARMv6 running into Raspberry pi, the
typo: into -> on a
> Source/WTF/ChangeLog:11
> + runtime crash.
typo: a runtime crash
> Source/WTF/ChangeLog:13
> + avoid runtime crash in such case.
typo: ditto "a runtime crash"
> Source/JavaScriptCore/runtime/ExceptionScope.cpp:60
> currentStack->dump(out, " ");
I think this should be:
if (currentStack)
currentStack->dump(out, " ");
given that the captureStackTrace function can return a nullptr.
I think you also need a null check on the
m_vm.nativeStackTraceOfLastThrow()->dump(out, " "); below.
More information about the webkit-reviews
mailing list