[webkit-reviews] review granted: [Bug 173646] [GCrypt] Implement CryptoKeyEC SPKI exports : [Attachment 313823] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173646: [GCrypt] Implement CryptoKeyEC SPKI exports
https://bugs.webkit.org/show_bug.cgi?id=173646

Attachment 313823: Patch

https://bugs.webkit.org/attachment.cgi?id=313823&action=review




--- Comment #8 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 313823
  --> https://bugs.webkit.org/attachment.cgi?id=313823
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313823&action=review

r=me. Looks good to me. Please address the following comments.

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:441
> +	   if (!PAL::TASN1::writeElement(spki, "algorithm.algorithm",
"1.2.840.10045.2.1", 1))

Should we use some sort of constants for "1.2.840.10045.2.1"? It should be
frequently used.