[webkit-reviews] review granted: [Bug 173997] Add TextStream operators for Range, VisiblePosition, VisibleSelection, and ScrollAlignment : [Attachment 314196] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 173997: Add TextStream operators for Range, VisiblePosition,
VisibleSelection, and ScrollAlignment
https://bugs.webkit.org/show_bug.cgi?id=173997

Attachment 314196: Patch

https://bugs.webkit.org/attachment.cgi?id=314196&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314196
  --> https://bugs.webkit.org/attachment.cgi?id=314196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314196&action=review

> Source/WebCore/ChangeLog:8
> +	   Just preserving logging so they can be used with TextStream-based
LOG_WITH_STREAM.

"preserving logging" for you, but that doesn't really make sense to future
readers of your changelog.

> Source/WebCore/rendering/ScrollAlignment.cpp:62
> +TextStream& operator<<(TextStream& ts, const ScrollAlignment::Behavior b)

No need for const.