[webkit-reviews] review granted: [Bug 173997] Add TextStream operators for Range, VisiblePosition, VisibleSelection, and ScrollAlignment : [Attachment 314195] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 173997: Add TextStream operators for Range, VisiblePosition,
VisibleSelection, and ScrollAlignment
https://bugs.webkit.org/show_bug.cgi?id=173997

Attachment 314195: Patch

https://bugs.webkit.org/attachment.cgi?id=314195&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314195
  --> https://bugs.webkit.org/attachment.cgi?id=314195
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314195&action=review

> Source/WebCore/ChangeLog:8
> +	   Just preserving logging I wrote for <rdar://problem/19005092>

This isn't interesting to future readers of this Changelog. Maybe just say "so
they can be used with TextStream-based LOG_WITH_STREAM.

> Source/WebCore/rendering/ScrollAlignment.cpp:62
> +TextStream& operator<<(TextStream& ts, const ScrollAlignment::Behavior& b)

No need to pass ScrollAlignment::Behavior as a reference. It's just an enum.

> Source/WebCore/rendering/ScrollAlignment.cpp:84
> +    return ts << "ScrollAlignment: visible: " << s.m_rectVisible << "
hidden: " << s.m_rectHidden << " partial: " <<s.m_rectPartial;

Missing space near the end.