[webkit-reviews] review granted: [Bug 173997] Some WebCore Logging : [Attachment 314193] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 29 17:26:06 PDT 2017


Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 173997: Some WebCore Logging
https://bugs.webkit.org/show_bug.cgi?id=173997

Attachment 314193: Patch

https://bugs.webkit.org/attachment.cgi?id=314193&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 314193
  --> https://bugs.webkit.org/attachment.cgi?id=314193
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314193&action=review

> Source/WebCore/ChangeLog:3
> +	   Some WebCore Logging

Could we make this bug title a bit more descriptive, perhaps so it references
VisibleSelection, RangeBoundaryPoint and ScrollAlignment?

> Source/WebCore/ChangeLog:8
> +	   Just preserving logging I wrote for a bug that got punted, no tests
needed.

...it might be helpful to reference the radar # here too.


More information about the webkit-reviews mailing list