[webkit-reviews] review granted: [Bug 173986] Web Inspector: Remove unnecessary hasChildren from TreeOutline : [Attachment 314180] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 29 17:21:44 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173986: Web Inspector: Remove unnecessary hasChildren from TreeOutline
https://bugs.webkit.org/show_bug.cgi?id=173986

Attachment 314180: Patch

https://bugs.webkit.org/attachment.cgi?id=314180&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 314180
  --> https://bugs.webkit.org/attachment.cgi?id=314180
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314180&action=review

> Source/WebInspectorUI/ChangeLog:24
> +2017-06-29  Devin Rousso  <drousso at apple.com>
> +
> +	   Web Inspector: TreeOutlines should mark hasChildren as false when
calling removeChildren
> +	   https://bugs.webkit.org/show_bug.cgi?id=173986

Double changelog.

Seems fine. r=me


More information about the webkit-reviews mailing list