[webkit-reviews] review granted: [Bug 173983] Web Inspector: Provide a way for creating a new tab but not making it immediately selected : [Attachment 314157] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 29 16:53:11 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173983: Web Inspector: Provide a way for creating a new tab but not making
it immediately selected
https://bugs.webkit.org/show_bug.cgi?id=173983
Attachment 314157: Patch
https://bugs.webkit.org/attachment.cgi?id=314157&action=review
--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 314157
--> https://bugs.webkit.org/attachment.cgi?id=314157
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=314157&action=review
>> Source/WebInspectorUI/UserInterface/Base/Main.js:-1123
>> - return WebInspector.CollectionContentView;
>
> Why is this getting removed?
r=me, but this deserves a comment in the ChangeLog. It looks like it is just
bad code, but its not in line with the rest of the patch so it deserves a
specific comment.
More information about the webkit-reviews
mailing list