[webkit-reviews] review granted: [Bug 173990] Split ResourceLoadObserver into 2 classes: one for WebCore and one for the UIProcess : [Attachment 314177] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 173990: Split ResourceLoadObserver into 2 classes: one for WebCore and one
for the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=173990

Attachment 314177: Patch

https://bugs.webkit.org/attachment.cgi?id=314177&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 314177
  --> https://bugs.webkit.org/attachment.cgi?id=314177
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314177&action=review

r=me. Once this lands we may be able to get rid of the locks entirely in a
follow-up patch.

> Source/WebCore/ChangeLog:9
> +	   They really have different API and there is therefore close to no
code duplication.

Yes -- maybe they should have significantly different names (in the future).