[webkit-reviews] review granted: [Bug 173961] [WebIDL] Add a new extended attribute to model the forced return value optimization used on Node and Crypto : [Attachment 314134] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 173961: [WebIDL] Add a new extended attribute to model the forced return
value optimization used on Node and Crypto
https://bugs.webkit.org/show_bug.cgi?id=173961

Attachment 314134: Patch

https://bugs.webkit.org/attachment.cgi?id=314134&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 314134
  --> https://bugs.webkit.org/attachment.cgi?id=314134
Patch

Regression test change for dot-node-base-exception.html looks like a
progression. Need to resolve that somehow before landing. Regenerating the test
result, removing the not-that-useful test since it is now quite obsolete and
handled well by general DOM bindings testing, or broadening the test to more
fully test what it originally intended to and not just covering the "too few
parameters" case.